# HG changeset patch # User Nick Wellnhofer <wellnhofer@aevum.de> # Date 1661292779 -7200 # Wed Aug 24 00:12:59 2022 +0200 # Node ID 72df6fbf6c3e83f8024736ccd3c1785a9619f141 # Parent 581fbc3e7c6ffa744bdf49cb473ee5b2fd93b6ed Fix update call in apibuild.py There are still a few places where try/except is used for branching. This is a bad idea since it can hide errors like this one. diff --git a/doc/apibuild.py b/doc/apibuild.py --- a/doc/apibuild.py +++ b/doc/apibuild.py @@ -192,10 +192,10 @@ if name[0:2] == '__': return None d = None - try: + if name in self.identifiers: d = self.identifiers[name] - d.update(header, module, type, lineno, info, extra, conditionals) - except: + d.update(header, module, type, info, extra, conditionals) + else: d = identifier(name, header, module, type, lineno, info, extra, conditionals) self.identifiers[name] = d @@ -214,10 +214,10 @@ if name[0:2] == '__': return None d = None - try: + if name in self.identifiers: d = self.identifiers[name] - d.update(header, module, type, lineno, info, extra, conditionals) - except: + d.update(header, module, type, info, extra, conditionals) + else: d = identifier(name, header, module, type, lineno, info, extra, conditionals) self.identifiers[name] = d