Skip to content
Snippets Groups Projects
Select Git revision
0 results

libyaml

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Michael Drake authored
    The document loading API (yaml_parser_load) was susseptable to a
    stack overflow issue when given input data which opened many
    mappings and/or sequences without closing them.
    
    This was due to the use of recurion in the implementation.
    
    With this change, we avoid recursion, and maintain our own loader
    context stack on the heap.
    
    The loader context contains a stack of document node indexes.
    Each time a sequence or mapping start event is encountered,
    the node index corrasponding to the event is pushed to the
    stack.  Each time a sequence or mapping end event is encountered,
    the corrasponding node's index is popped from the stack.
    
    The yaml_parser_load_nodes() function sits on the event stream,
    issuing events to the appropriate handlers by type.
    
    When an event handler function constructs a node, it needs to
    connect the new node to its parent (unless it's the root node).
    This is where the loader context stack is used to find the
    parent node.  The way that the new node is added to the tree
    depends on whether the parent node is a mapping (with a
    yaml_node_pair_t to fill), or a sequence (with a yaml_node_item_t).
    
    Fixes: https://github.com/yaml/libyaml/issues/107
    191d6417
    History
    Name Last commit Last update