Skip to content
Snippets Groups Projects
Select Git revision
5 results

configure.ac

Blame
    • Jessica Clarke's avatar
      6f48cece8020
      bpo-43179: Generalise alignment for optimised string routines (GH-24624) · 6f48cece8020
      Jessica Clarke authored
      * Remove m68k-specific hack from ascii_decode
      
      On m68k, alignments of primitives is more relaxed, with 4-byte and
      8-byte types only requiring 2-byte alignment, thus using sizeof(size_t)
      does not work. Instead, use the portable alternative.
      
      Note that this is a minimal fix that only relaxes the assertion and the
      condition for when to use the optimised version remains overly strict.
      Such issues will be fixed tree-wide in the next commit.
      
      NB: In C11 we could use _Alignof(size_t) instead, but for compatibility
      we use autoconf.
      
      * Optimise string routines for architectures with non-natural alignment
      
      C only requires that sizeof(x) is a multiple of alignof(x), not that the
      two are equal. Thus anywhere where we optimise based on alignment we
      should be using alignof(x) not sizeof(x).
      
      This is more annoying than it would be in C11 where we could just use
      _Alignof(x) (and alignof(x) in C++11), but since we still require only
      C99 we must plumb the information all the way from autoconf through the
      various typedefs and defines.
      6f48cece8020
      History
      bpo-43179: Generalise alignment for optimised string routines (GH-24624)
      Jessica Clarke authored
      * Remove m68k-specific hack from ascii_decode
      
      On m68k, alignments of primitives is more relaxed, with 4-byte and
      8-byte types only requiring 2-byte alignment, thus using sizeof(size_t)
      does not work. Instead, use the portable alternative.
      
      Note that this is a minimal fix that only relaxes the assertion and the
      condition for when to use the optimised version remains overly strict.
      Such issues will be fixed tree-wide in the next commit.
      
      NB: In C11 we could use _Alignof(size_t) instead, but for compatibility
      we use autoconf.
      
      * Optimise string routines for architectures with non-natural alignment
      
      C only requires that sizeof(x) is a multiple of alignof(x), not that the
      two are equal. Thus anywhere where we optimise based on alignment we
      should be using alignof(x) not sizeof(x).
      
      This is more annoying than it would be in C11 where we could just use
      _Alignof(x) (and alignof(x) in C++11), but since we still require only
      C99 we must plumb the information all the way from autoconf through the
      various typedefs and defines.