Skip to content
Snippets Groups Projects
Commit 05d2fe56ddbf authored by Jeff Forcier's avatar Jeff Forcier
Browse files

Only override unittest assertions when absolutely necessary.

Fixes #85
parent e53caa0c2162
Branches
No related tags found
No related merge requests found
...@@ -18,6 +18,11 @@ ...@@ -18,6 +18,11 @@
* #90: Ensure that callbacks handed to `SFTPClient.get()` always fire at least * #90: Ensure that callbacks handed to `SFTPClient.get()` always fire at least
once, even for zero-length files downloaded. Thanks to Github user `@enB` for once, even for zero-length files downloaded. Thanks to Github user `@enB` for
the catch. the catch.
* #85: Paramiko's test suite overrides
`unittest.TestCase.assertTrue/assertFalse` to provide these modern assertions
to Python 2.2/2.3, which lacked them. However on newer Pythons such as 2.7,
this now causes deprecation warnings. The overrides have been patched to only
execute when necessary. Thanks to `@Arfrever` for catch & patch.
v1.8.0 (3rd Oct 2012) v1.8.0 (3rd Oct 2012)
......
...@@ -107,4 +107,5 @@ ...@@ -107,4 +107,5 @@
class TransportTest (unittest.TestCase): class TransportTest (unittest.TestCase):
if not hasattr(unittest.TestCase, 'assertTrue'):
assertTrue = unittest.TestCase.failUnless # for Python 2.3 and below assertTrue = unittest.TestCase.failUnless # for Python 2.3 and below
...@@ -110,4 +111,5 @@ ...@@ -110,4 +111,5 @@
assertTrue = unittest.TestCase.failUnless # for Python 2.3 and below assertTrue = unittest.TestCase.failUnless # for Python 2.3 and below
if not hasattr(unittest.TestCase, 'assertFalse'):
assertFalse = unittest.TestCase.failIf # for Python 2.3 and below assertFalse = unittest.TestCase.failIf # for Python 2.3 and below
def setUp(self): def setUp(self):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment